Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Modules: Fix maxnetblock size check in several modules #1701

Merged
merged 1 commit into from
Jun 13, 2022

Conversation

bcoles
Copy link
Contributor

@bcoles bcoles commented Jun 12, 2022

In some modules max_netblock is defined then subsequently overwritten with a potentially invalid value.

@codecov-commenter
Copy link

codecov-commenter commented Jun 12, 2022

Codecov Report

Merging #1701 (b9b0921) into master (368fe2b) will increase coverage by 0.00%.
The diff coverage is 0.00%.

@@           Coverage Diff           @@
##           master    #1701   +/-   ##
=======================================
  Coverage   46.47%   46.48%           
=======================================
  Files         709      709           
  Lines       46758    46754    -4     
=======================================
  Hits        21733    21733           
+ Misses      25025    25021    -4     
Impacted Files Coverage Δ
modules/sfp_alienvault.py 19.69% <ø> (+0.07%) ⬆️
modules/sfp_fraudguard.py 25.00% <0.00%> (+0.19%) ⬆️
modules/sfp_pulsedive.py 25.98% <ø> (+0.20%) ⬆️
modules/sfp_robtex.py 17.46% <ø> (+0.13%) ⬆️

📣 Codecov can now indicate which changes are the most critical in Pull Requests. Learn more

@smicallef smicallef merged commit c643a50 into smicallef:master Jun 13, 2022
@bcoles bcoles deleted the modules-maxnetblock branch June 14, 2022 02:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants