Skip to content

Commit

Permalink
Fix regression with passing args through to JVM
Browse files Browse the repository at this point in the history
Python's *args in a method definition creates a tuple, not a list; and
tuples can't be concatenated with lists.
  • Loading branch information
ept committed Jun 15, 2012
1 parent 08224b2 commit ff9b528
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion bin/storm
Original file line number Diff line number Diff line change
Expand Up @@ -108,7 +108,7 @@ def exec_storm_class(klass, jvmtype="-server", jvmopts=[], extrajars=[], args=[]
"-Dstorm.home=" + STORM_DIR,
"-Djava.library.path=" + confvalue("java.library.path", extrajars),
"-cp", get_classpath(extrajars),
] + jvmopts + [klass] + args
] + jvmopts + [klass] + list(args)
print "Running: " + " ".join(all_args)
if fork:
os.spawnvp(os.P_WAIT, "java", all_args)
Expand Down

0 comments on commit ff9b528

Please sign in to comment.