-
-
Notifications
You must be signed in to change notification settings - Fork 3.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Some Columns (Vanilla) are not displayed even when saved in Cookie #10482
Comments
I'm seeing the same behavior on Safari running within Mac OS Monterey. I'm running Snipe It on Debian 11 with PHP 8.0.14. |
I noticed the same behaviour within my fresh install. (v5.3.8 - build 6619, Docker) |
We’re working on this issue. Thanks so much for your continued patience. |
We're still working on this issue btw |
We may have accidentally fixed this issue as we were fixing something else - can you pull from master and see if you can still reproduce this behavior? |
Just pulled and updated my instance (Version v5.4.1 - build 6746 (master)) and I'm still seeing this behavior on most columns. |
What browser are you using? |
(I am unable to replicate the issue anymore on Chrome, Brave, Edge, and Safari - all MacOS.) |
Chrome 99.0.4844.82, Windows 10 Pro 21H2 |
Also in the demo "Check out a live, up-to-date version of the master branch of Snipe-IT." v5.4.1 build 6746 (g3e22dce11) Again, it's only the by default deactivated columns. Custom and default activated once work fine (on/off). 373d1b3b-c3d0-4dba-9454-6f0ef4355390.mp4 |
I made AlexanderWPapyrus' change to Company, Model No., Purchase Date, Order Number, and Notes in my AssetPresenter.php and these columns now behave as expected. |
Tried the changes from @AlexanderWPapyrus and they are working like a charm for us, too - thanks! This could be also used for us to set a "default view" as many of other people requested here. |
Unfortunatelly problem still exist for v5.4.1 - build 6746 (master) and also for v6.0.0-RC-7 - build 6787 (develop), tested on Chrome 100.0.4896.60 and Edge 99.0.1150.55 For me still working solution is to use for replace file snipe-it/public/js/dist/bootstrap-table.js from v5.3.3 |
|
@AlexanderWPapyrus In general, it's a bad idea to do this, as it can cause problems upgrading, and it's very likely we upgraded the version of bootstrap tables due to a security vulnerability in the JS library. (We don't generally just upgrade libraries for no reason.) |
@AlexanderWPapyrus That sort of doesn't make any sense though... https://github.com/snipe/snipe-it/blob/v5.3.3/package.json#L35 locks the version in at 1.19.1 for 5.3.3, which is the same as the one from 5.4.1: https://github.com/snipe/snipe-it/blob/v5.4.1/package.json#L35
|
Hi @snipe , Our next big modification will be that as soon the user signs an asset, we get the acceptance email again but with the signature, so we can print it out and hand it over to our HR department. I'm just waiting for #9529 So in our case upgrading is always a hassle 😅 |
For me replace file snipe-it/public/js/dist/bootstrap-table.js from v5.3.3 it's working and file between 5.3.3 and newer one 5.3.8 / 5.4.1 is different. |
@Robert-Azelis okay, but we literally are using the same versions in both, as I showed you - both of which are latest from bootstrap-tables. |
sorry to say, but content both files are different (compared 5.3.3 with 5.4.1): |
Very weird and very interesting. When I check this out, this is what I see:
So maybe it's the locked packages?
Those seem to be relatively trivial changes between the two. Maybe it's some other strange artifact of the build? Like, we built the JS on 'too new' of a node.js version, or 'too old', or something? |
okay, I re-read this entire thing from the beginning and re-tested it. And I can definitely confirm it's very much still broken. And I can also confirm that v5.3.3 works. So I just kinda need to bisect the code to find out where it broke. Easy peasy. |
Fix #10482 for develop - Downgrade bootstrap-table to fix remembered-columns feature
Hi all. Just wanted to let you know that while the issue appears to be gone when playing around within |
This problem has re-appeared - seems to only be happening in Chromium based browsers (Chrome, Edge) but Firefox works fine. Version: v7.0.11 build 15044 (g46ed07642) |
@shanemartin22 We have not heard of any other reports of this issue. This issue is from 2022. Please create a new issue and fill in all of the questions in the new issue form. (When you reply to old, closed threads, it sends an email notification to everyone who ever participated in it, which can be pretty annoying to have happen on a thread that's been resolved for a while.) You can try switching to local storage instead of cookies, but I can't reproduce this. |
Debug mode
Describe the bug
Hi,
we updated to v5.3.6 and now some coulums are not displayed after a page reload. It seems like the cookie is saved (maybe wrong)
I just tested with ID, Company and Model Number (probably more coulumns are affected (custom work fine)).
I first tested on clean installed browsers on multiple machines, then checked the cookie with an addon.
It seems that the by default displayed/enabled coulumns are working fine.
Couldn't see any errors in debug mode.
Hope you can reproduce (No, actually I hope it's just us 😬)
Best wishes and thanks for this awesome project,
Alex
Reproduction steps
1.Reproducable also in demo with freshly setup windows client (Chrome, FF, Edge)
2.see GIF below
Expected behavior
Show selected coulumns after page refresh/change
Screenshots
Snipe-IT Version
v5.3.6
Operating System
Server Ubuntu, client Windows
Web Server
Apache
PHP Version
7.2.34-2+ubuntu18.04.1+deb.sury.org+1upgraded to
7.4.27
(No difference regarding issue)
Operating System
Windows 10
Browser
Google Chrome, FireFox, Edge
Version
No response
Device
No response
Operating System
No response
Browser
No response
Version
No response
Error messages
Additional context
No response
The text was updated successfully, but these errors were encountered: