Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Checkin time always show 12AM #10866

Closed
2 tasks done
szalayzoli11 opened this issue Mar 23, 2022 · 5 comments · Fixed by #10920
Closed
2 tasks done

Checkin time always show 12AM #10866

szalayzoli11 opened this issue Mar 23, 2022 · 5 comments · Fixed by #10920
Assignees
Labels
✋ bug Confirmed bug

Comments

@szalayzoli11
Copy link

Debug mode

Describe the bug

When you try to check in an asset the dashboard always show 12AM checkin time

Reproduction steps

...

Expected behavior

show correct check in time

Screenshots

No response

Snipe-IT Version

5.4.1; 6.0

Operating System

win

Web Server

apache2

PHP Version

7.4

Operating System

No response

Browser

No response

Version

No response

Device

No response

Operating System

No response

Browser

No response

Version

No response

Error messages

No response

Additional context

No response

@john159753
Copy link

I can confirm I see this issue as well.
Version v5.4.1 - build 6746
MariaDB v10.7
PHP v7.4

According to the action_logs table - it seems like only the "checkin from" action that is not recording time data in the "action_date" field.

Let me know if I can provide more detail!

@szalayzoli11
Copy link
Author

szalayzoli11 commented Apr 6, 2022 via email

@snipe
Copy link
Owner

snipe commented Apr 7, 2022

thx I have an suspicion, that someone play with the github contents also.. :(

I don't know what that means - all of our changes are public. https://github.com/snipe/snipe-it/commits/master

I know huge task check the all code, but that is a strange thing, that something workable, and after few days i see something changed a little and the same version generate this errors...

We push changes often and only tag a release once every few weeks or so (if that). I don't think there's anything nefarious happening here.

Can anyone reproduce this on the demo? https://demo.snipeitapp.com (admin/password).

@inietov - can you take a peek?

GitHub
A free open source IT asset/license management system - Commits · snipe/snipe-it

@szalayzoli11
Copy link
Author

szalayzoli11 commented Apr 7, 2022 via email

@snipe snipe added the ✋ bug Confirmed bug label Apr 7, 2022
@snipe
Copy link
Owner

snipe commented Apr 7, 2022

@inietov @Godmartinz Two things here:

  1. I can reproduce this on develop and master.

master:
Screen Shot 2022-04-07 at 3 56 33 PM

This artifact seems to happen when we clear out the "checkin date" field or let the system input it. (I'd expect 12:00 if you set a checkin date there, since we don't know what time, but if we're just using "now" as the checkin date time, it should honor the current date and time.)

  1. On develop, we may have introduced a new bug.

Same issue exists with checkin time, but also we're adding extra entries into the action_logs table here for each of the side-effects:

Screen Shot 2022-04-07 at 3 55 59 PM

I'm not sure what changed, but can you two work together (via slack or however) to see what might be happening here?

Thanks!

@snipe snipe changed the title checkin time always show 12AM Checkin time always show 12AM Apr 7, 2022
snipe added a commit that referenced this issue Apr 7, 2022
…_always_shows_12am-master

Fixed #10866 - action_date for check-in not including H:i:s
snipe added a commit that referenced this issue Apr 7, 2022
…_show_12am

Fixed #10866 - Checkin time always shows 12am
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
✋ bug Confirmed bug
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants