Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added session killer artisan command #10814

Merged
merged 3 commits into from
Mar 10, 2022

Conversation

snipe
Copy link
Owner

@snipe snipe commented Mar 10, 2022

Simple artisan command to logout all users - especially useful when using the restore command. If you restore without killing all sessions, and your user ID isn't the same, your session will persist, and you could be logged in as someone else. (This is why we destroy sessions in v6 on the GUI restore.)

Using the --force flag will override confirmation prompts, in the event we want to use this non-interactively.

Signed-off-by: snipe snipe@snipe.net

Signed-off-by: snipe <snipe@snipe.net>
Signed-off-by: snipe <snipe@snipe.net>
Signed-off-by: snipe <snipe@snipe.net>
Copy link
Collaborator

@uberbrady uberbrady left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yup! This is great. And if we eventually do get to a point where we need a version of this for other session stores, I think this will be the right vehicle to do it. In the UI-backed restore, we should probably invoke this command as well, yeah?

@snipe snipe merged commit 7cbcd2d into master Mar 10, 2022
@snipe snipe deleted the features/add_clear_sessions_artisan_command branch March 10, 2022 21:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants