Fix bs tables export options #10857
Merged
Fix bs tables export options #10857
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This grabs the attribute-based export options that we set on each table and ensures those export options are properly respected.
Because I had to change the nesting-level of the indented JS object, the change shows up bigger than it really is. Probably best to try and 'ignore whitespace' when looking at this.
The htmlContent bit that we do makes the CSV exports super-duper gross, and I hate that. I don't know a good way to work around that though; I'm pretty sure we put that in to avoid XSS attacks, and I would like to continue to do that. There are some kinda-interesting table-export options we might be able to use in order to screen out potential XSS though? We'll have to talk it over.
But, with this change, the appropriate columns are correctly ignored, and the downloaded export file is appropriately named. Yay.