Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FIX] Update EOL date when used bulk update of purchase date #14671

Merged
merged 1 commit into from
Sep 19, 2024

Conversation

Robert-Azelis
Copy link
Contributor

Fix update EOL date when used bulk update of purchase date

Description

I noticed that if is used bulk update of purchase date then EOL date is not updated, this modification fix this issue.

Fixes # (issue)

Type of change

  • Bug fix (non-breaking change which fixes an issue)

How Has This Been Tested?

Test Configuration:

  • PHP version: 8.1
  • MySQL version 10.6.5-MariaDB
  • Webserver version IIS
  • Web browser: MS Edge, Chrome

Checklist:

Fix for bulk updarte of purchase date to calculate new EOL
Copy link

what-the-diff bot commented May 2, 2024

PR Summary

  • Introduction of a New Date Library
    Our developers have incorporated a new date library called 'Carbon' in the file BulkAssetsController.php. This allows us to handle dates and times in a more efficient and more accurate way.

  • Setting Asset End-of-Life Date
    The developers have added conditions to automatically assign an end-of-life date (EoL date) to assets. This helps in effective asset management by predicting when the assets will no longer be useful or functional.

  • Handling Null Asset End-of-Life Dates
    A new feature has also been included that will assign a null value to an asset's EoL date when certain conditions are met. This ensures effective data handling and accuracy when an asset's EoL date cannot be predicted or is not available.

@spencerrlongg
Copy link
Collaborator

Hey @Robert-Azelis, I'm not turning this down right now and at first glance it looks great, but I'm right in the middle of writing some tests and some possible changes on the BulkAssetsController (we keep working on the same files at the same time!).

More importantly, we're right in the middle of our final push to get v7 released, so I'll keep this open and get back to it (and your other PR) as soon as we've got that all out the door.

Sorry for my lack of communication about it and thanks for your patience!

@spencerrlongg spencerrlongg self-assigned this May 7, 2024
@spencerrlongg spencerrlongg self-requested a review May 7, 2024 22:39
@snipe
Copy link
Owner

snipe commented Aug 22, 2024

@spencerrlongg given v7 and your changes, is this still valid?

@Robert-Azelis
Copy link
Contributor Author

@spencerrlongg given v7 and your changes, is this still valid?

from my side still valid. I use it couple of months in my company.

@snipe snipe merged commit 4f7c8e0 into snipe:develop Sep 19, 2024
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants