Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes for requiredness indicator in UI #15573

Merged
merged 3 commits into from
Sep 28, 2024
Merged

Conversation

snipe
Copy link
Owner

@snipe snipe commented Sep 28, 2024

This should fix a regression introduced in #15552, where the requiredness wasn't consistently indicated anymore since switched from a regular class to a pseudo class.

@Godmartinz One thing I noticed here was that we're not accounting for textareas in the CSS. We should probably add that at some point to keep things consistent.

There were a few places where I just pulled the check, since it would never be true.

Signed-off-by: snipe <snipe@snipe.net>
Signed-off-by: snipe <snipe@snipe.net>
@snipe snipe changed the title Fixes for requiredness display Fixes for requiredness display in UI Sep 28, 2024
@snipe snipe changed the title Fixes for requiredness display in UI Fixes for requiredness indicator in UI Sep 28, 2024
Copy link

what-the-diff bot commented Sep 28, 2024

PR Summary

  • Increased visibility of required fields
    Border thickness around required input and selection elements in the user interface has been increased, which will make it easier for users to identify mandatory fields.

  • Enhancement of multiple-selection
    Improved styling for multiple-selection fields in forms has been introduced, which will provide a better user experience.

  • Updates to Blade template files
    Amendments have been made to the layout of these files, enhancing the clarity of the code and facilitating future development work.

  • Consistency in required field identification
    The marking method for required fields has been standardized across different parts of the system, providing a more consistent user experience.

  • Refinement of the checkout form
    An asset selection element has been added to the checkout form in order to facilitate the selection of multiple assets at once.

  • Improvement of form structure
    Redundant class and attribute logic has been reduced, and Bootstrap grid system usage has been standardized, which will benefit overall performance and readability of code.

  • Enhancement of accessibility
    Required fields are now clearly marked in both the field label and input tag, allowing users to easily identify necessary fields.

  • Removal of unnecessary checks
    Superfluous checks for required class in form groups have been removed from some files, optimizing the system efficiency.

  • Simplified error handling
    The process of handling errors for input fields has been streamlined, which will improve speed and usability.

  • Consolidation of code practices
    Minor syntax corrections have been carried out to ensure consistency and adherence to best practices in coding.

Signed-off-by: snipe <snipe@snipe.net>
@snipe snipe merged commit 260b153 into develop Sep 28, 2024
9 checks passed
@snipe snipe deleted the fixed_requiredness_indicator branch September 28, 2024 15:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant