feat: bump CLI dependencies to use patched @snyk/lodash #1093
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
requested review from
lili2311
force-pushed
the
feat/bump-deps-to-use-patched-lodash
branch
from
3e98f05
to
46a49c2
Compare
lili2311
changed the title
joeholdcroft
force-pushed
the
feat/bump-deps-to-use-patched-lodash
branch
from
dc11f22
to
adbb303
Compare
anthogez
reviewed
Apr 29, 2020
anthogez
previously approved these changes
Apr 29, 2020
|
@anthogez we could go with any but then we lose all types which we have types for that |
lili2311
force-pushed
the
feat/bump-deps-to-use-patched-lodash
branch
2 times, most recently
from
b041f27
to
1a826c3
Compare
This was referenced Apr 29, 2020
Merged
gitphill
force-pushed
the
feat/bump-deps-to-use-patched-lodash
branch
from
201f6ea
to
2885e61
Compare
Vulnerability in lodash@4.17.15 No fix available so using @snyk/lodash Using @snyk/inquirer and @snyk/graphlib because of transitive dependencies on vulnerable lodash Bump to snyk internal packages that include lodash patch
joeholdcroft
force-pushed
the
feat/bump-deps-to-use-patched-lodash
branch
from
2885e61
to
c359e05
Compare
gitphill
approved these changes
Apr 30, 2020
|
🎉 This PR is included in version 1.316.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Bump CLI dependencies to use non-vulnerable forked version of lodash or remove it entirely.
As part of this fix all transitives that rely on
lodashhave been updated to use non-vulnerable@snyk/lodashinsteadLinks