Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add monitor call graph metrics #1105

Merged
merged 1 commit into from
May 5, 2020

Conversation

darmalovan
Copy link

@darmalovan darmalovan commented May 5, 2020

  • Ready for review
  • Follows CONTRIBUTING rules
  • Reviewed by Snyk internal team

What does this PR do?

Add call graph metrics to snyk monitor

Where should the reviewer start?

How should this be manually tested?

Any background context you want to provide?

What are the relevant tickets?

Screenshots

Additional questions

@darmalovan darmalovan requested a review from a team as a code owner May 5, 2020 08:35
@darmalovan darmalovan self-assigned this May 5, 2020
@ghost ghost requested review from lili2311 and orsagie May 5, 2020 08:35
@darmalovan darmalovan requested review from anthogez and removed request for lili2311 and orsagie May 5, 2020 08:36
anthogez
anthogez previously approved these changes May 5, 2020
Copy link
Member

@anthogez anthogez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, just run prettier and you ready

@darmalovan
Copy link
Author

@anthogez fixed the linting

@darmalovan
Copy link
Author

@anthogez if you can approve... :)

@darmalovan darmalovan merged commit 358794f into master May 5, 2020
@darmalovan darmalovan deleted the feat/add-call-graph-metrics-to-monitor branch May 5, 2020 09:24
@snyksec
Copy link

snyksec commented May 5, 2020

🎉 This PR is included in version 1.319.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants