Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: updated test command so Circle will test properly #1113

Merged
merged 1 commit into from
May 11, 2020
Merged

fix: updated test command so Circle will test properly #1113

merged 1 commit into from
May 11, 2020

Conversation

aviadhahami
Copy link
Contributor

  • Ready for review

What does this PR do?

Updated the CircleCi step where it invoked test incorrectly;

Slack thread

@aviadhahami aviadhahami requested a review from a team as a code owner May 11, 2020 15:11
@aviadhahami aviadhahami self-assigned this May 11, 2020
@ghost ghost requested review from dkontorovskyy and lili2311 May 11, 2020 15:11
@maxjeffos maxjeffos self-requested a review May 11, 2020 15:17
anthogez
anthogez approved these changes May 11, 2020
View reviewed changes
Copy link
Member

@anthogez anthogez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@aviadhahami aviadhahami merged commit 9b31d2b into master May 11, 2020
@aviadhahami aviadhahami deleted the fix/circle-to-run-npm-test branch May 11, 2020 15:30
@snyksec
Copy link

snyksec commented May 11, 2020

🎉 This PR is included in version 1.320.2 🎉

The release is available on:

Your semantic-release bot 📦🚀

@robin-qualityengineer robin-qualityengineer mentioned this pull request May 23, 2022
Open
This was referenced May 23, 2022
Open
Open
@froscheimer froscheimer mentioned this pull request May 24, 2022
Open
@snyk-bot snyk-bot mentioned this pull request May 24, 2022
Open
@snyk-bot snyk-bot mentioned this pull request Jun 24, 2022
Open
@EitanGayor EitanGayor mentioned this pull request Jun 30, 2022
Open
@aliscco aliscco mentioned this pull request Aug 5, 2022
Open
@snyk-bot snyk-bot mentioned this pull request Sep 24, 2022
Open
This was referenced Sep 25, 2022
Open
Open
@snyk-bot snyk-bot mentioned this pull request Oct 1, 2022
Open
@aliscco aliscco mentioned this pull request Oct 2, 2022
Open
@snyk-bot snyk-bot mentioned this pull request Oct 4, 2022
Closed
@snyk-bot snyk-bot mentioned this pull request Oct 29, 2022
Open
@snyk-bot snyk-bot mentioned this pull request Dec 6, 2022
Open
@snyk-bot snyk-bot mentioned this pull request Jan 12, 2023
Open
This was referenced Feb 15, 2023
Open
Merged
Open
@EitanGayor EitanGayor mentioned this pull request Mar 10, 2023
Open
@snyk-bot snyk-bot mentioned this pull request Mar 12, 2023
Open
@cloudgeek7 cloudgeek7 mentioned this pull request Mar 15, 2023
Open
@snyk-bot snyk-bot mentioned this pull request Apr 6, 2023
Open
@EitanGayor EitanGayor mentioned this pull request Apr 29, 2023
Open
@snyk-bot snyk-bot mentioned this pull request May 29, 2023
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@anthogez anthogez anthogez approved these changes

@dkontorovskyy dkontorovskyy Awaiting requested review from dkontorovskyy

@lili2311 lili2311 Awaiting requested review from lili2311

@maxjeffos maxjeffos Awaiting requested review from maxjeffos

Assignees

@aviadhahami aviadhahami

Labels
released 🚀 Boost
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@aviadhahami @snyksec @anthogez