Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(test): use shellspec for regression test #1287

Merged
merged 1 commit into from
Jul 28, 2020
Merged

chore(test): use shellspec for regression test #1287

merged 1 commit into from
Jul 28, 2020

Conversation

JackuB
Copy link
Contributor

@JackuB JackuB commented Jul 27, 2020 •
edited
Loading

Replaced the "Common" step with "Smoke tests". It's using the same spec files as our GitHub Action smoke tests.
Also simplified the dependency graph:

Screenshot 2020-07-28 at 09 31 02

@JackuB JackuB force-pushed the chore/improve-regression-test branch from b05aca7 to 942d13b Compare July 27, 2020 11:09
@snyksec
Copy link

snyksec commented Jul 27, 2020 •
edited
Loading

Messages
📖

This PR will not trigger a new version. It doesn't include any commit message with feat or fix.

Generated by 🚫 dangerJS against 37c42c9

@JackuB JackuB force-pushed the chore/improve-regression-test branch 20 times, most recently from a08d276 to fe5759e Compare July 28, 2020 07:31
@JackuB JackuB requested a review from pavel-snyk July 28, 2020 07:32
@JackuB JackuB marked this pull request as ready for review July 28, 2020 07:32
@JackuB JackuB requested review from a team as code owners July 28, 2020 07:32
@ghost ghost requested review from aviadhahami and gitphill July 28, 2020 07:32
@JackuB JackuB force-pushed the chore/improve-regression-test branch from fe5759e to 37c42c9 Compare July 28, 2020 08:28
pavel-snyk
pavel-snyk approved these changes Jul 28, 2020
View reviewed changes
Copy link
Contributor

@pavel-snyk pavel-snyk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@JackuB JackuB merged commit 6db7e51 into master Jul 28, 2020
@JackuB JackuB deleted the chore/improve-regression-test branch July 28, 2020 10:23
@snyksec
Copy link

snyksec commented Jul 28, 2020

🎉 This PR is included in version 1.368.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

@snyk-bot snyk-bot mentioned this pull request Aug 7, 2020
Open
This was referenced Aug 16, 2020
Open
Open
Open
Open
This was referenced Aug 27, 2020
Open
Open
Open
Open
@EitanGayor EitanGayor mentioned this pull request Feb 22, 2021
Open
@romathur romathur mentioned this pull request Feb 22, 2021
Open
@EitanGayor EitanGayor mentioned this pull request Feb 23, 2021
Open
@joshje joshje mentioned this pull request Feb 23, 2021
Open
@RyanPHigh RyanPHigh mentioned this pull request Feb 23, 2021
Open
@snyk-bot snyk-bot mentioned this pull request Jul 27, 2022
Closed
This was referenced Jul 31, 2022
Open
Open
@swinton swinton mentioned this pull request Aug 2, 2022
Closed
@snyk-bot snyk-bot mentioned this pull request Sep 30, 2022
Open
@shaniHerz shaniHerz mentioned this pull request Oct 3, 2022
Closed
@snyk-bot snyk-bot mentioned this pull request Feb 19, 2023
Merged
@AliADDOU AliADDOU mentioned this pull request Apr 15, 2024
Open
@romathur romathur mentioned this pull request Apr 16, 2024
Open
@RyanPHigh RyanPHigh mentioned this pull request Apr 16, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pavel-snyk pavel-snyk pavel-snyk approved these changes

@aviadhahami aviadhahami Awaiting requested review from aviadhahami

@gitphill gitphill Awaiting requested review from gitphill

Assignees
No one assigned
Labels
released
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@JackuB @snyksec @pavel-snyk