feat: improve error reporting for reachable vulnerabilities #1314
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
requested review from
--reachable flag wasn't working correctly on windows machines, this is the transitive update of a dependency with a fix
|
Expected release notes (by @miiila) features: fixes: others (will not be included in Semantic-Release notes):
|
JackuB
approved these changes
Aug 7, 2020
gitphill
approved these changes
Aug 7, 2020
|
🎉 This PR is included in version 1.370.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
This was referenced Jan 17, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Bump the Maven plugin version, and make some small adjustments to accommodate the changes in error reporting introduced in the latest version.
Also fixes --reachable behaviour on Windows
How should this be manually tested?
Run
snyk test -d --reachable --reachable-timeout=5, and check the error reported for call graph generation.What are the relevant tickets?
https://snyksec.atlassian.net/browse/FLOW-373
Screenshots