Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(test): add regression test for valid JSON bodies #1327

Merged
merged 1 commit into from
Aug 14, 2020
Merged

chore(test): add regression test for valid JSON bodies #1327

merged 1 commit into from
Aug 14, 2020

Conversation

JackuB
Copy link
Contributor

@JackuB JackuB commented Aug 13, 2020 •
edited
Loading

Following an issue with extraneous output in stderr with --json and --all-projects flags #1324

screenshot_2020-08-13_at_17 23 26

This PR:

  • adds a test for scenario above
  • adds a jq dependency to validate command output is a valid JSON

@snyksec
Copy link

snyksec commented Aug 13, 2020 •
edited
Loading

Messages
📖

This PR will not trigger a new version. It doesn't include any commit message with feat or fix.

Generated by 🚫 dangerJS against 41e8de2

@JackuB JackuB requested a review from pavel-snyk August 13, 2020 15:57
@JackuB JackuB marked this pull request as ready for review August 13, 2020 16:03
@JackuB JackuB requested review from a team as code owners August 13, 2020 16:03
@ghost ghost requested review from anthogez and dkontorovskyy August 13, 2020 16:03
pavel-snyk
pavel-snyk approved these changes Aug 13, 2020
View reviewed changes
Copy link
Contributor

@pavel-snyk pavel-snyk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, nice catch with printf

@JackuB JackuB merged commit c49d942 into master Aug 14, 2020
@JackuB JackuB deleted the feat/smoke-test branch August 14, 2020 09:26
@snyksec
Copy link

snyksec commented Aug 14, 2020

🎉 This PR is included in version 1.374.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

@iuliams iuliams mentioned this pull request May 13, 2022
Closed
This was referenced May 13, 2022
Open
Open
Open
@snyk-bot snyk-bot mentioned this pull request May 13, 2022
Open
This was referenced May 14, 2022
Open
Open
This was referenced May 14, 2022
Open
Open
@cloudgeek7 cloudgeek7 mentioned this pull request May 14, 2022
Open
@aliscco aliscco mentioned this pull request May 14, 2022
Open
@cloudgeek7 cloudgeek7 mentioned this pull request May 14, 2022
Open
@aliscco aliscco mentioned this pull request May 14, 2022
Open
@aliscco aliscco mentioned this pull request May 14, 2022
Open
@cloudgeek7 cloudgeek7 mentioned this pull request May 14, 2022
Open
@aliscco aliscco mentioned this pull request May 14, 2022
Open
@AriSorsko AriSorsko mentioned this pull request Aug 3, 2022
Closed
This was referenced Sep 23, 2022
Open
Open
This was referenced Sep 24, 2022
Open
Open
Open
This was referenced Sep 25, 2022
Open
Closed
@pavel-snyk pavel-snyk mentioned this pull request Sep 30, 2022
Closed
@soniqua soniqua mentioned this pull request Sep 30, 2022
Closed
@snyk-bot snyk-bot mentioned this pull request Sep 30, 2022
Closed
@pavel-snyk pavel-snyk mentioned this pull request Sep 30, 2022
Closed
This was referenced Oct 3, 2022
Closed
Closed
Closed
@shaniHerz shaniHerz mentioned this pull request Oct 4, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gitphill gitphill gitphill approved these changes

@pavel-snyk pavel-snyk pavel-snyk approved these changes

@anthogez anthogez Awaiting requested review from anthogez

@dkontorovskyy dkontorovskyy Awaiting requested review from dkontorovskyy

Assignees
No one assigned
Labels
released
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@JackuB @snyksec @gitphill @pavel-snyk