-
Notifications
You must be signed in to change notification settings - Fork 555
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: determine correct LockfileType for yarn v2 #1336
Conversation
Hey @mhassan1 thanks for your contribution! We actually already have detection for yarn v2 in our parser, but you pointed out that we were not doing it in both |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Big 👍
closing and reopening to trigger test |
@mhassan1 I need to create a separate branch to trigger the tests. Can you send me your email so I can add you as contributor? to or@snyk.io |
@orsagie I raised a PR and cherry-picked the commit :) Closing this one |
What does this PR do?
Adds support for Yarn v2 with the
--yarn-workspaces
flagWhere should the reviewer start?
package.json
How should this be manually tested?
snyk test --yarn-workspaces
in a Yarn v2 package that contains Yarn WorkspacesWhat are the relevant tickets?
https://github.com/snyk/snyk/issues/1322