Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: check if scanned project does have a callgraph #1361

Merged

Conversation

darmalovan
Copy link

@darmalovan darmalovan commented Aug 25, 2020

  • Ready for review
  • Follows CONTRIBUTING rules
  • Reviewed by Snyk internal team

What does this PR do?

When running with snyk test --reachable --all-projects and one of the projects is not supported for reachable vulns
i.e. not maven, we are failing with this error Cannot read property 'message' of undefined”..

This change makes sure that the project does have a call graph.

Where should the reviewer start?

How should this be manually tested?

Any background context you want to provide?

What are the relevant tickets?

Screenshots

Additional questions

When running with `snyk test --reachable --all-projects`
and one of the projects is not supported for reachable vulns
i.e. not maven, we are failing.

This change makes sure that the project does have a
call graph.
@darmalovan darmalovan requested review from a team as code owners August 25, 2020 11:08
@darmalovan darmalovan self-assigned this Aug 25, 2020
@ghost ghost requested review from aviadhahami and gitphill August 25, 2020 11:08
@github-actions
Copy link
Contributor

github-actions bot commented Aug 25, 2020

Expected release notes (by @darmalovan)

fixes:
check if scanned project does have a callgraph (2d11938)

others (will not be included in Semantic-Release notes):
update yarn workspaces support commands help text (e5c3e48)

  • I hereby acknowledge these release notes are 🥙 AWESOME 🥙

@darmalovan darmalovan merged commit 1f5c7e9 into master Aug 25, 2020
@darmalovan darmalovan deleted the fix/snyk-test-fails-with-reachable-vulns-and-all-projects branch August 25, 2020 12:37
@snyksec
Copy link

snyksec commented Aug 25, 2020

🎉 This PR is included in version 1.382.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants