Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: explicitly write we support K8s only (IaC) #1364

Merged
merged 1 commit into from
Aug 25, 2020

Conversation

orkamara
Copy link
Contributor

  • Ready for review
  • Follows CONTRIBUTING rules
  • Reviewed by Snyk internal team

What does this PR do?

Explicitly mention that we support K8s only right now (as part of IaC)

Any background context you want to provide?

https://snyk.slack.com/archives/CRV0PMFDH/p1598243270020000

@orkamara orkamara requested review from rontalx and a team August 25, 2020 13:06
@orkamara orkamara self-assigned this Aug 25, 2020
@github-actions
Copy link
Contributor

github-actions bot commented Aug 25, 2020

Warnings
⚠️ You've modified files in src/ directory, but haven't updated anything in test folder. Is there something that could be tested?

Generated by 🚫 dangerJS against 8be11a4

@rontalx
Copy link
Contributor

rontalx commented Aug 25, 2020

Maybe update in our iac test help output as well?
https://github.com/snyk/snyk/blob/master/help/iac.txt#L5

Currently it says:

Find security issues in your Infrastructure as Code files.

@orkamara orkamara force-pushed the feat/iac-support-k8s-only-alert branch from 1c692f8 to 8be11a4 Compare August 25, 2020 14:25
@github-actions
Copy link
Contributor

github-actions bot commented Aug 25, 2020

Expected release notes (by @orkamara)

features:
explicitly write we support K8s only (IaC) (8be11a4)

others (will not be included in Semantic-Release notes):
add VS launch.json config (9255e70)

  • I hereby acknowledge these release notes are 🥙 AWESOME 🥙

@orkamara
Copy link
Contributor Author

Maybe update in our iac test help output as well?
https://github.com/snyk/snyk/blob/master/help/iac.txt#L5

Currently it says:

Find security issues in your Infrastructure as Code files.

Great idea @rontalx 💪

@orkamara orkamara merged commit 56c9198 into master Aug 25, 2020
@orkamara orkamara deleted the feat/iac-support-k8s-only-alert branch August 25, 2020 15:38
@snyksec
Copy link

snyksec commented Aug 25, 2020

🎉 This PR is included in version 1.384.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants