Feat:exit code 3 when no projects detected #1386
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lili2311
force-pushed
the
feat/exit-code-for-no-projects
branch
4 times, most recently
from
ae28322
to
255a8e3
Compare
ghost
requested review from
lili2311
commented
Sep 3, 2020
| @@ -51,7 +51,9 @@ function executeTest(root, options) { | |||
| return results; | |||
| }); | |||
| } catch (error) { | |||
| return Promise.reject(chalk.red.bold(error)); | |||
| return Promise.reject( | |||
| chalk.red.bold(error.message ? error.message : error), | |||
There was a problem hiding this comment.
fix to drop Custom Error from displayed errors.
lili2311
commented
Sep 4, 2020
| @@ -10,9 +10,23 @@ Describe "Snyk test command" | |||
| snyk test | |||
| } | |||
|
|
|||
| It "throws error when file does not exist" | |||
There was a problem hiding this comment.
Test passing locally:
lili2311
force-pushed
the
feat/exit-code-for-no-projects
branch
from
255a8e3
to
809a73f
Compare
JackuB
approved these changes
Sep 4, 2020
| @@ -43,6 +43,7 @@ const debug = Debug('snyk'); | |||
| const EXIT_CODES = { | |||
| VULNS_FOUND: 1, | |||
| ERROR: 2, | |||
| NO_SUPPORTED_MANIFESTS_FOUND: 3, | |||
There was a problem hiding this comment.
Could you please also document this somewhere? Readme or help.txt
There was a problem hiding this comment.
Documented:
|
Expected release notes (by @lili2311) features: others (will not be included in Semantic-Release notes):
|
|
🎉 This PR is included in version 1.389.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
lili2311
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Add a new Exit Code when non supported manifests were detected so we could not conduct a test.
https://github.com/snyk/snyk/issues/1135
Where should the reviewer start?
https://github.com/snyk/snyk/compare/feat/exit-code-for-no-projects#diff-ebd6539fe4cc61b013d83b586f268b8aR93
How should this be manually tested?
snyk testrun an empty folder for example