feat: add reachable vulnerabilities support for gradle #1422
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
requested review from
miiila
force-pushed
the
feat/add-reachable-vulns-support-for-gradle
branch
2 times, most recently
from
6c1614d
to
7064c37
Compare
darmalovan
force-pushed
the
feat/add-reachable-vulns-support-for-gradle
branch
5 times, most recently
from
7205e76
to
3276847
Compare
anthogez
reviewed
Sep 29, 2020
test/reachable-vulns.test.ts
Outdated
| const mavenIndex = pkgManagers.indexOf('maven'); | ||
| pkgManagers.splice(mavenIndex, 1); // remove maven as it's supported | ||
| const pkgManagers = Object.keys(SUPPORTED_PACKAGE_MANAGER_NAME).filter( | ||
| (name: any) => !REACHABLE_VULNS_SUPPORTED_PACKAGE_MANAGERS.includes(name), |
There was a problem hiding this comment.
I suggest name: string instead of name: any
anthogez
reviewed
Sep 29, 2020
| @@ -79,7 +79,7 @@ | |||
| "snyk-cpp-plugin": "2.0.0", | |||
| "snyk-docker-plugin": "3.24.0", | |||
| "snyk-go-plugin": "1.16.2", | |||
| "snyk-gradle-plugin": "3.6.3", | |||
| "snyk-gradle-plugin": "3.7.0", | |||
There was a problem hiding this comment.
reviewed also changes introduced here
snyk/snyk-gradle-plugin@453a81e
anthogez
approved these changes
Sep 29, 2020
darmalovan
force-pushed
the
feat/add-reachable-vulns-support-for-gradle
branch
from
3276847
to
a0e7460
Compare
|
Expected release notes (by @darmalovan) features:
|
JackuB
approved these changes
Sep 29, 2020
|
🎉 This PR is included in version 1.405.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
This was referenced Jan 17, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Adds reachable vulnerabilities feature support for Gradle projects.