fix: sarif descirption change #1428
Conversation
ghost
requested review from
RotemS
force-pushed
the
fix/sarif-output-changes
branch
from
87feb1c
to
13b5b6f
Compare
| @@ -1,4 +1,5 @@ | |||
| import * as sarif from 'sarif'; | |||
| import upperFirst = require('lodash/upperFirst'); | |||
There was a problem hiding this comment.
I would like to recommend import { upperFirst } from 'lodash'; instead of import upperFirst = require('lodash/upperFirst');
There was a problem hiding this comment.
Would be nice also to fix the commit message to something that is more related to what you have added into the description of your pr:
small change to SARIF output description, severity to look the same in IaC and containers.
To give more context to our users of what is happening
There was a problem hiding this comment.
This was actually a change requested on the PR that introduced this functionality, I originally used your suggestion :) Don't mind changing if needed
There was a problem hiding this comment.
We are reducing the usage of require giving the preference to import
| @@ -1,4 +1,5 @@ | |||
| import * as sarif from 'sarif'; | |||
| import upperFirst = require('lodash/upperFirst'); | |||
There was a problem hiding this comment.
You can't use import?
| import upperFirst = require('lodash/upperFirst'); | |
| import upperFirst from 'lodash/upperFirst'; |
There was a problem hiding this comment.
This solution would not help because upperFirst was exported as export = upperFirst;
and in order to allow it we need to change tsconfig.json compilerOptions and add a new property
"esModuleInterop": true,
There was a problem hiding this comment.
Was a request in the original PR. Considering the two comments on this now, changed 👍
RotemS
force-pushed
the
fix/sarif-output-changes
branch
2 times, most recently
from
101e8bd
to
9702a0e
Compare
RotemS
force-pushed
the
fix/sarif-output-changes
branch
from
9702a0e
to
4abfb97
Compare
|
🎉 This PR is included in version 1.405.1 🎉 The release is available on: Your semantic-release bot 📦🚀 |
What does this PR do?
Small change to SARIF output description, severity to look the same in IaC and containers.