Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: container test should not run app vulns scan by default #1445

Merged
merged 1 commit into from
Oct 6, 2020

Conversation

ahmed-agabani-snyk
Copy link
Contributor

@ahmed-agabani-snyk ahmed-agabani-snyk commented Oct 6, 2020

  • Ready for review
  • Follows CONTRIBUTING rules
  • Reviewed by Snyk internal team

What does this PR do?

removes containers test default --app-vulns scan

How should this be manually tested?

  • snyk container test mladkau/snykin

Any background context you want to provide?

Slack Thread

What are the relevant tickets?

DC-852

@ghost ghost requested review from gitphill and MegaBean October 6, 2020 10:53
@github-actions
Copy link
Contributor

github-actions bot commented Oct 6, 2020

Expected release notes (by @ahmed-agabani-snyk)

fixes:
container test should not run app vulns scan by default (b62c1c0)

  • I hereby acknowledge these release notes are 🥙 AWESOME 🥙

@ahmed-agabani-snyk ahmed-agabani-snyk merged commit f77e7b0 into master Oct 6, 2020
@ahmed-agabani-snyk ahmed-agabani-snyk deleted the feat/app-vulns-parameter-2 branch October 6, 2020 14:26
@snyksec
Copy link

snyksec commented Oct 6, 2020

🎉 This PR is included in version 1.410.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants