-
Notifications
You must be signed in to change notification settings - Fork 555
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: execute all tests with lerna to test all packages #1646
Conversation
1781ed0
to
58bf4b9
Compare
5be46dc
to
80b0149
Compare
@@ -227,7 +230,7 @@ jobs: | |||
command: echo "//registry.npmjs.org/:_authToken=$env:NPM_TOKEN" >> .npmrc | |||
- run: | |||
name: Install dependencies (Windows) | |||
command: npm install --ignore-scripts # ignore-scripts required because of postinstall script in snyk-resolve-deps package |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
no longer needed as snyk-resolve-deps
postinstall was migrated to prepare
a643dc5
to
249f5be
Compare
@JackuB please 👀 |
565bf8c
to
2a2cf08
Compare
Lerna can execute all package tests found in the repo https://github.com/lerna/lerna/tree/main/commands/run#readme
2a2cf08
to
e7d7a34
Compare
@@ -128,7 +128,7 @@ describe('Analytics basic testing', () => { | |||
'integrationEnvironmentVersion', | |||
].sort(), | |||
); | |||
}); | |||
}, 10000); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
these were super flaky and not completing in a default given time
@@ -241,25 +247,25 @@ jobs: | |||
steps: | |||
- run: | |||
name: Run "Root" tap tests | |||
command: npm run test:test | |||
command: lerna run test:test --stream |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
So is the plan that each package will have a task called test:test
and test:jest
? I think it's just a limitation of the current CLI that we have tests split like this.
How about removing the test
script from the root package.json (as we can't/don't use it now) and just have a lerna run test
that will test packages? We might even have a single container dedicated for that now
What does this PR do?
Run commands that need to be run on all packages with Lerna, and use
npm
for the rest.Lerna can execute all package tests found in the repo
https://github.com/lerna/lerna/tree/main/commands/run#readme