feat: add init-script argument to CLI for gradle #1647
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
juanamari94
force-pushed
the
feat/init-script
branch
from
9c84820
to
b84486b
Compare
darmalovan
reviewed
Feb 18, 2021
juanamari94
force-pushed
the
feat/init-script
branch
2 times, most recently
from
0b3764c
to
f4dc37f
Compare
aviadhahami
approved these changes
Feb 18, 2021
init-script is part of gradle and is used for certain use cases such as private artifact inventories. This is required for reachability in order to get the classpath required for building the call graph. Upgrades snyk-gradle-plugin to v3.13.0
juanamari94
force-pushed
the
feat/init-script
branch
from
f4dc37f
to
859f71d
Compare
|
Expected release notes (by @juanamari94) features:
|
JackuB
reviewed
Feb 18, 2021
| @@ -179,6 +181,7 @@ export type SupportedUserReachableFacingCliArgs = | |||
| | 'reachable-vulns' | |||
| | 'reachable-timeout' | |||
| | 'reachable-vulns-timeout' | |||
| | 'init-script' | |||
There was a problem hiding this comment.
So you don't need to pass this option, it'll just be picked from the global options?
There was a problem hiding this comment.
I'm not quite certain what you mean. Should I remove it then? As far as I understand it's better to have types set here for documentation concerns.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR was submitted by @pwnslinger, this pull request was opened because CircleCI is unable to pull a forked repository. Credit where it's due, this fix was created by @pwnslinger as well.
What does this PR do?
init-script is part of gradle and is used for certain use cases such as private artifact inventories.
This is required for reachability in order to get the classpath required for building the call graph.
How should this be manually tested?
Using a gradle project, create a file
init.gradlefor example and runsnyk test -d --file=./build.gradle --insecure --severity-threshold=medium --reachable --init-script=init.gradleor
snyk monitor -d --file=./build.gradle --insecure --severity-threshold=medium --reachable --init-script=init.gradleAny background context you want to provide?
We need the inner gradle commands of the java call graph builder to succeed in order to retrieve the classpath that allows us to get a call graph from the project.
What are the relevant tickets?
https://snyksec.atlassian.net/browse/FLOW-649