-
Notifications
You must be signed in to change notification settings - Fork 555
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: upgrade semantic-release #181
Conversation
053026e
to
3cd1e5b
Compare
3c526b1
to
d48f8de
Compare
4da2ca7
to
609cb27
Compare
.travis.yml
Outdated
# tests are failing on npm@5, remove this once this is not an issue | ||
- npm i -g npm@^3.0.0 | ||
# tests are failing on npm@5, downgrade to npm@3 if >3 is installed | ||
- test "$(npm -v | cut -d'.' -f1)" -le 3 || npm i -g npm@^3.0.0 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This will downgrade to npm@3 on node8, but not override npm@2 on node4.
609cb27
to
12f4347
Compare
node_js: | ||
- "8" | ||
- "6" | ||
- "4" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Moving nodejs versions to travis (parallel build stages) in order to enable the release job as a separate stage.
12f4347
to
184a7ed
Compare
@@ -12,14 +12,11 @@ | |||
"node": ">=4" | |||
}, | |||
"scripts": { | |||
"coverage": "tap --cov --coverage-report=lcov test/*.test.js", | |||
"tap": "COVERALLS_REPO_TOKEN=0 tap --timeout=180 --cov --coverage-report=text-summary test/*.test.js", | |||
"tap": "tap test/*.test.js -R spec --timeout=180", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Removing coveralls
, unifying appveyor and travis test target.
"lint": "jscs `find ./cli -name '*.js'` -v && jscs `find ./lib -name '*.js'` -v", | ||
"check-tests": "! grep 'test\\.only' test/*.test.js -n", | ||
"semantic-release": "semantic-release pre && npm publish && semantic-release post", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
semantic-release
is external to the package.json
file, managed via travis settings.
@@ -70,7 +67,6 @@ | |||
"nock": "^9.2.5", | |||
"proxyquire": "^1.7.4", | |||
"restify": "^4.1.1", | |||
"semantic-release": "^8", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
semantic-release
is external to the package.json
file, managed via travis settings.
@@ -1,122 +0,0 @@ | |||
import os |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This script used to coordinate semantic-release
when it ran as part of the leader job. No longer needed with a standalone release job.
|
||
# upload assets built by `pkg` | ||
# GH_TOKEN is set as Travis env var | ||
GITHUB_TOKEN=$GH_TOKEN npx github-release upload --owner snyk --repo snyk --tag "v${SNYK_VERSION}" --name "v${SNYK_VERSION}" ./snyk-linux ./snyk-macos ./snyk-win.exe |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is copied from our internal documentation, please verify correctness :)
include: | ||
- stage: Release | ||
node_js: "8" | ||
script: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Changing this from after_success
to script
so that if it fails, the job fails
47a9efb
to
3d63cae
Compare
🎉 This PR is included in version 1.90.1 🎉 The release is available on: Your semantic-release bot 📦🚀 |
What does this PR do?
Upgrade
semantic-release
to^15
, catching up with time!npm
, andsemantic-release
pulls in the latestnpm
version, we're not usingsemantic-release
as a dev dependency, but install it just in time for the release.Adjust travis and appveyor settings.