Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: show only unique vulnerabilities in sarif format #1909

Merged
merged 1 commit into from
May 18, 2021

Conversation

admons
Copy link
Contributor

@admons admons commented May 12, 2021

Today in sarif output we have a result item per each "vulnerable path"
This will reduce the number of items to be the number of vulnerabilities

@admons admons requested review from a team as code owners May 12, 2021 13:06
@github-actions
Copy link
Contributor

github-actions bot commented May 12, 2021

Warnings
⚠️ You've modified files in src/ directory, but haven't updated anything in test folder. Is there something that could be tested?

Generated by 🚫 dangerJS against 713edf3

Copy link
Contributor

@aviadhahami aviadhahami left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Today in sarif output we have a result item per each "vulnerable path"
This will reduce the number of items to be the number of vulnerabilities
@github-actions
Copy link
Contributor

github-actions bot commented May 18, 2021

Expected release notes (by @admons)

features:
show only unique vulnerabilities in sarif format (713edf3)

  • I hereby acknowledge these release notes are 🥙 AWESOME 🥙

@admons admons merged commit a5177b2 into master May 18, 2021
@admons admons deleted the fix/sarif-unique-results branch May 18, 2021 10:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants