Remove default HTML report from Docker images #2091
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
marked this pull request as draft
1 task
JackuB
force-pushed
the
chore/remove-jq-from-docker
branch
from
98234b0
to
8eb1261
Compare
This also removes jq usage and prevents errors being thrown on non-json output
JackuB
force-pushed
the
chore/remove-jq-from-docker
branch
from
8eb1261
to
cdc35ac
Compare
ghost
approved these changes
Aug 27, 2021
|
For the record, I think this was ill-advised as it was a major breaking change. It broke our automated Snyk jobs and the pipelines that used them, requiring us to scramble for solutions. |
JackuB
added a commit
that referenced
this pull request
Sep 30, 2021
JackuB
added a commit
that referenced
this pull request
Sep 30, 2021
revert: partial revert of Dockerfile changes from #2091
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This also removes jq usage and prevents errors being thrown on non-json output
Jenkins plugin is not relying on these fields anymore.
And the
jqwas throwing errors for non-JSON outputs for no reason and kep confusing people.Fixes #1633