feat: sequential fix #2252
Merged
feat: sequential fix #2252
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lili2311
force-pushed
the
feat/sequential-fix
branch
4 times, most recently
from
d082aca
to
31d50d6
Compare
|
lili2311
force-pushed
the
feat/sequential-fix
branch
from
31d50d6
to
abae6e8
Compare
Support optionally upgrading 1 package at a time, this is much slower but can provide better success in upgrading vulnerable package versions
lili2311
force-pushed
the
feat/sequential-fix
branch
from
abae6e8
to
1901672
Compare
Move throwable code into try/catch to make sure we continue fixing + spinner is not stuck Update a test to show that if some dependencies fail under --sequentially-fix we can still update other dependencies.
lili2311
force-pushed
the
feat/sequential-fix
branch
from
1901672
to
d820026
Compare
lili2311
commented
Sep 14, 2021
| const changes: FixChangesSummary[] = []; | ||
| try { | ||
| const { upgrades } = await generateUpgrades(entity); |
There was a problem hiding this comment.
move back into try/catch to not prevent further fixes & to let the spinner finish
lili2311
force-pushed
the
feat/sequential-fix
branch
5 times, most recently
from
c85ba8e
to
6cd1266
Compare
if asked fix a package 1 by 1, this is much slower but can increase success % when some packages might be incompatible
lili2311
force-pushed
the
feat/sequential-fix
branch
from
6cd1266
to
b587e46
Compare
aarlaud
approved these changes
Sep 14, 2021
jan-stehlik
approved these changes
Sep 15, 2021
lili2311
force-pushed
the
feat/sequential-fix
branch
from
d6a8735
to
a5a618c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Support optionally upgrading 1 package at a time, this
is much slower but can provide better success in upgrading
vulnerable package versions
Any background context you want to provide?
Some combination of package upgraded might not be compatible, allow upgrading 1 at a time to increase the % of fixed issues. This is much slower 🐌
snyk fix --sequentialwill trigger the behavior to try applying package upgrades viapoetryandpipenv1 by 1.Screenshots
Can't see a difference in the screenshot unless one of the upgrades fails. See the added test to show what to expect.
Actual project run
From a test that crafts the right scenario, when running with
--sequential-fixthe whole fix does not fail.