feat: replace YAML parser with library call [CC-1012] #2260
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
teodora-sandu
force-pushed
the
feat/replace-yaml-parser
branch
2 times, most recently
from
9b1b564
to
b473e27
Compare
teodora-sandu
requested review from
craigfurman,
tonidevine1,
ipapast and
rontalx
and removed request for
craigfurman and
ipapast
craigfurman
approved these changes
Sep 17, 2021
teodora-sandu
force-pushed
the
feat/replace-yaml-parser
branch
4 times, most recently
from
00b9fe2
to
e8ff8ae
Compare
|
Good shout on the package-lock.json. I followed the instructions in this thread to fix it: https://snyk.slack.com/archives/C1NREQSG0/p1631814339032800 |
anthogez
approved these changes
Sep 20, 2021
jan-stehlik
approved these changes
Sep 20, 2021
ghost
approved these changes
Sep 20, 2021
teodora-sandu
force-pushed
the
feat/replace-yaml-parser
branch
from
e8ff8ae
to
0d75edc
Compare
This was referenced May 18, 2023
Merged
Merged
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
This PR replaces the
yamllibrary with a call to@snyk/cloud-config-parser, where we have moved our customised YAML parsing logic. This way when we have parsing issues that we need to fix, we can fix them in just one place.How should this be manually tested?
Run:
npm run buildsnyk-dev iac test ./test/fixtures/iac/kubernetes/pod-privileged.yamlsnyk-dev iac test ./test/fixtures/iac/kubernetes/pod-valid.jsonWhat are the relevant tickets?
https://snyksec.atlassian.net/browse/CC-1012
Screenshots