fix: update yaml parser to fix parsing [CC-1175] #2268
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
This PR updates the version of
@snyk/cloud-config-parserin order to fix a parsing inconsistency where\/doesn't fail parsing in the YAML JavaScript parser.How should this be manually tested?
I've tested this locally by importing a repo that has an IaC YAML file where one of they keys has a value like
"\/"Test\/""Any background context you want to provide?
This will hopefully reduce the number of error logs that cause this alert to hit us every day: https://snyk.slack.com/archives/C023NA9FQCU/p1632279068000600
What are the relevant tickets?
Screenshots
We can see a comparison of the before (
snyk-dev) and after (snyk).Now, the fail correctly isn't considered valid YAML and the CLI scanning is consistent with the SCM import as per https://github.com/snyk/registry/pull/23716.