Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: apply resolutions to all yarn workspaces in a project #2285

Merged

Conversation

JamesPatrickGill
Copy link
Member

@JamesPatrickGill JamesPatrickGill commented Sep 28, 2021

What does this PR do?

This reproduces the behaviour in yarn2 where root resolutions apply to all workspaces and workspace resolutions are ignored.

Ideally merged once this goes in snyk/nodejs-lockfile-parser#126

@github-actions
Copy link
Contributor

github-actions bot commented Sep 28, 2021

Warnings
⚠️

Since the CLI is unifying on a standard and improved tooling, we're starting to migrate old-style imports and exports to ES6 ones.
A file you've modified is using either module.exports or require(). If you can, please update them to ES6 import syntax and export syntax.
Files found:

  • src/lib/plugins/nodejs-plugin/yarn-workspaces-parser.ts

Generated by 🚫 dangerJS against 33c50be

@JamesPatrickGill JamesPatrickGill force-pushed the feat/merge-root-resolutions-with-ws-manifests branch 2 times, most recently from 1246e57 to 6d3f270 Compare October 1, 2021 09:01
@JamesPatrickGill JamesPatrickGill requested review from a team and admons and removed request for a team October 1, 2021 09:01
@JamesPatrickGill JamesPatrickGill marked this pull request as ready for review October 1, 2021 09:01
@JamesPatrickGill JamesPatrickGill requested review from a team as code owners October 1, 2021 09:01
@JamesPatrickGill JamesPatrickGill force-pushed the feat/merge-root-resolutions-with-ws-manifests branch from 6d3f270 to 05e446d Compare October 1, 2021 10:06
@JamesPatrickGill JamesPatrickGill force-pushed the feat/merge-root-resolutions-with-ws-manifests branch from 05e446d to 33c50be Compare October 1, 2021 10:11
Copy link
Contributor

@jan-stehlik jan-stehlik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice one @JamesPatrickGill 🚢

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants