Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: improve share results error handling #3070

Closed
wants to merge 1 commit into from

Conversation

YairZ101
Copy link
Contributor

What does this PR do?

This PR improves how we handle errors we receive from the IaC Share Results endpoint by doing a small refactoring.

@YairZ101 YairZ101 requested a review from a team as a code owner March 28, 2022 13:24
@YairZ101 YairZ101 requested review from wbeuil and teodora-sandu and removed request for wbeuil March 28, 2022 13:24
Copy link
Contributor

@teodora-sandu teodora-sandu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@YairZ101 YairZ101 force-pushed the feat/new-share-results-error-handling branch 3 times, most recently from 67a796d to 15cd920 Compare March 29, 2022 08:19
@YairZ101 YairZ101 requested review from a team as code owners March 29, 2022 08:19
@YairZ101 YairZ101 force-pushed the feat/new-share-results-error-handling branch from 15cd920 to 09a35d8 Compare March 29, 2022 08:22
@YairZ101 YairZ101 closed this Mar 31, 2022
@darscan darscan deleted the feat/new-share-results-error-handling branch January 20, 2023 18:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants