Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: Extracted output methods and updated color utilities #3150

Merged
merged 2 commits into from
Apr 19, 2022

Conversation

ofekatr
Copy link
Contributor

@ofekatr ofekatr commented Apr 18, 2022

What does this PR do?

  • Updates the color utilities for the new CLI output to include the info and success colors, and applying them to the relevant output sections.
  • Extracts output functions and messages for the initial user message and share results, and adds tests for them.

Where should the reviewer start?

  • src/lib/formatters/iac-output/v2/color-utils.ts
  • src/cli/commands/test/iac/index.ts

@github-actions
Copy link
Contributor

github-actions bot commented Apr 18, 2022

Warnings
⚠️

Since the CLI is unifying on a standard and improved tooling, we're starting to migrate old-style imports and exports to ES6 ones.
A file you've modified is using either module.exports or require(). If you can, please update them to ES6 import syntax and export syntax.
Files found:

  • src/cli/commands/test/iac/index.ts
  • src/lib/formatters/iac-output/v2/issues-list.ts

Generated by 🚫 dangerJS against 4665f47

@ofekatr ofekatr force-pushed the chore/update-color-utils branch 3 times, most recently from d111782 to a758322 Compare April 18, 2022 15:29
@ofekatr ofekatr changed the title chore: Updated color utils refactor: Extracted output functions and updated color utilities Apr 19, 2022
@ofekatr ofekatr changed the title refactor: Extracted output functions and updated color utilities refactor: Extracted output methods and updated color utilities Apr 19, 2022
@ofekatr ofekatr marked this pull request as ready for review April 19, 2022 07:42
@ofekatr ofekatr requested a review from a team as a code owner April 19, 2022 07:42
Copy link
Contributor

@francescomari francescomari left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I love what you did here!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants