fix: include the custom rules warning if feature flag is not enabled [CFG-1868] #3316
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ofekatr
approved these changes
Jun 13, 2022
| ); | ||
|
|
||
| expect(stdout).not.toContain( | ||
| "Please note that your custom rules will not be sent to the Snyk platform, and will not be available on the project's page.", |
There was a problem hiding this comment.
nit: The message could be extracted and reused as a constant in the test suite to clarify it's the same message
teodora-sandu
force-pushed
the
fix/include-custom-rules-warning
branch
3 times, most recently
from
4071997
to
17d458a
Compare
teodora-sandu
force-pushed
the
fix/include-custom-rules-warning
branch
from
17d458a
to
44e892b
Compare
This was referenced May 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
In #3287, we removed the warning for custom rules completely, but we were meant to only remove it if the feature flag is enabled.
Where should the reviewer start?
Have a look at the previous PR and notice the added feature flag check in this PR.
How should this be manually tested?
The ticket can be verified using https://github.com/snyk/custom-rules-examples/
snyk-iac-rules buildsnyk iac test ./rules/CUSTOM-RULE-1/fixtures --rules=bundle.tar.gzsnyk-dev iac test ./rules/CUSTOM-RULE-1/fixtures --rules=bundle.tar.gz --report