Feat/update vuln urls to point to security.snyk.io #3448
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
e102
changed the title
|
e102
force-pushed
the
feat/update_vuln_urls_to_pvdb
branch
from
2d8ddf3
to
2fd7018
Compare
e102
force-pushed
the
feat/update_vuln_urls_to_pvdb
branch
from
2fd7018
to
6128f25
Compare
e102
force-pushed
the
feat/update_vuln_urls_to_pvdb
branch
from
1b5f3b2
to
3b5fcf7
Compare
| @@ -41,7 +41,7 @@ export function notificationForSpotlightVulns( | |||
| ); | |||
|
|
|||
| for (const vulnId of foundSpotlightVulnsIds) { | |||
| message += ` - ${vulnId} (See https://snyk.io/vuln/${vulnId})`; | |||
| message += ` - ${vulnId} (See https://security.snyk.io/vuln/${vulnId})`; | |||
There was a problem hiding this comment.
issue(blocking): Whilst we're in this area can we switch to using the configuration value rather than a hard coded string?
For example:
Suggested change
| message += ` - ${vulnId} (See https://security.snyk.io/vuln/${vulnId})`; | |
| message += ` - ${vulnId} (See ${config.PUBLIC_VULN_DB_URL}/vuln/${vulnId})`; |
thisislawatts
approved these changes
Jul 12, 2022
Avishagp
approved these changes
Jul 13, 2022
orsagie
approved these changes
Jul 13, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Updates URL links for vulns in the CLI output to point to security.snyk.io, the new snyk vulnerability db which generally has better UX and more info than the legacy site the links are currently pointing to.