Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Ensure the test spinner stops #3566

Merged
merged 1 commit into from
Aug 11, 2022
Merged

Conversation

ofekatr
Copy link
Contributor

@ofekatr ofekatr commented Aug 10, 2022

What does this PR do?

  • Ensures the spinner for the experimental test flow stops, no matter if the flow fails or ends successfully.

Where should the reviewer start?

src/cli/commands/test/iac/v2/index.ts

How should this be manually tested?

  • Run the experimental test flow in a way that should make it fail, e.g., provide a custom ruleset bundle path to a non-existing ruleset.
  • Ensure the spinner disappears as expected.

Screenshots

  • Before:
    image
  • After:
    image

@ofekatr ofekatr requested a review from ipapast August 10, 2022 14:12
@ofekatr ofekatr requested a review from a team as a code owner August 10, 2022 14:12
@ofekatr ofekatr changed the title fix: Ensured the test spinner stops fix: Ensure the test spinner stops Aug 10, 2022
@github-actions
Copy link
Contributor

github-actions bot commented Aug 10, 2022

Warnings
⚠️

You've modified files in src/ directory, but haven't updated anything in test folder. Is there something that could be tested?

Generated by 🚫 dangerJS against 5d9d15f

@ofekatr ofekatr enabled auto-merge August 10, 2022 14:23
@ofekatr ofekatr force-pushed the fix/ensure-iac-test-spinner-stops branch from 4f12e15 to 6232c05 Compare August 11, 2022 08:44
@ofekatr ofekatr force-pushed the fix/ensure-iac-test-spinner-stops branch from 6232c05 to 5d9d15f Compare August 11, 2022 08:47
@ofekatr ofekatr merged commit 71f2b16 into master Aug 11, 2022
@ofekatr ofekatr deleted the fix/ensure-iac-test-spinner-stops branch August 11, 2022 09:19
@Jimimaku
Copy link

What does this PR do?

  • Ensures the spinner for the experimental test flow stops, no matter if the flow fails or ends successfully.

Where should the reviewer start?

src/cli/commands/test/iac/v2/index.ts

How should this be manually tested?

  • Run the experimental test flow in a way that should make it fail, e.g., provide a custom ruleset bundle path to a non-existing ruleset.
  • Ensure the spinner disappears as expected.

Screenshots

  • Before:
    image
  • After:
    image

@ofekatr
Copy link
Contributor Author

ofekatr commented Aug 11, 2022

@Jimimaku Your comment above only copied the content of the PR's description. Did you mean to quote something and comment on it?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants