Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add support for Node 18 #4903

Closed
wants to merge 4 commits into from
Closed

feat: add support for Node 18 #4903

wants to merge 4 commits into from

Conversation

cat2608
Copy link
Contributor

@cat2608 cat2608 commented Oct 11, 2023

What does this PR do?

This PR updates Node.js version from 16.16.0 to 18.18.1:

  • Updates .nvmrc which is used in the Makefile and create-build-image.sh script.
  • Modifies the engines field in package.json and package-lock.json.
  • Adds logs in both the Docker build process and the CircleCI configuration to display the installed Node.js version.

Any background context you want to provide?

Previous steps for this job see #4882 #4866

What are the relevant tickets?

HEAD-497

@cat2608 cat2608 marked this pull request as ready for review October 12, 2023 08:43
@cat2608 cat2608 requested review from a team as code owners October 12, 2023 08:43
PeterSchafer
PeterSchafer requested changes Oct 12, 2023
View reviewed changes
Copy link
Collaborator

@PeterSchafer PeterSchafer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Issue: please review the failing tests.

@cat2608 cat2608 closed this Oct 18, 2023
@cat2608 cat2608 deleted the feat/HEAD-497-add-support-node-18 branch October 23, 2023 08:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@PeterSchafer PeterSchafer PeterSchafer requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@cat2608 @PeterSchafer