Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: support node 18 [HEAD-497] #4910

Closed
wants to merge 20 commits into from

Conversation

PeterSchafer
Copy link
Collaborator

@PeterSchafer PeterSchafer commented Oct 18, 2023

What does this PR do?

This PR updates Node.js version from 16.16.0 to 18.18.1:

  • Updates .nvmrc which is used in the Makefile and create-build-image.sh script.
  • Modifies the engines field in package.json and package-lock.json.
  • Update and fix tap tests

Any background context you want to provide?

Previous steps for this job see #4882 #4866

What are the relevant tickets?

HEAD-497

@PeterSchafer PeterSchafer requested review from a team as code owners October 18, 2023 09:41
@github-actions
Copy link
Contributor

github-actions bot commented Oct 18, 2023

Warnings
⚠️

Since the CLI is unifying on a standard and improved tooling, we're starting to migrate old-style imports and exports to ES6 ones.
A file you've modified is using either module.exports or require(). If you can, please update them to ES6 import syntax and export syntax.
Files found:

  • test/tap/cli-monitor.acceptance.test.ts
  • test/tap/cli-test/cli-test.docker.spec.ts
  • test/tap/cli-test/cli-test.ruby.spec.ts
  • test/tap/cli-test/cli-test.sbt.spec.ts
  • test/tap/cli.test.ts
  • test/tap/monitor-target.test.ts

Generated by 🚫 dangerJS against 5b6dc0e

@PeterSchafer PeterSchafer force-pushed the smoke/HEAD-497-add-support-node-18 branch from cafedc3 to 63cba99 Compare October 18, 2023 10:26
Copy link
Contributor

@cat2608 cat2608 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🙌

@PeterSchafer PeterSchafer deleted the smoke/HEAD-497-add-support-node-18 branch October 18, 2023 11:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants