Refactor/module info #526
Merged
Refactor/module info #526
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lili2311
force-pushed
the
refactor/module-info
branch
from
fb3ea93
to
cd5e993
Compare
lili2311
force-pushed
the
refactor/module-info
branch
from
cd5e993
to
b8de2b9
Compare
kyegupov
approved these changes
May 21, 2019
| inspect: async function (root, targetFile, options) { | ||
| var pluginOptions = _.merge({ | ||
| async inspect(root, targetFile, options) { | ||
| const pluginOptions = _.merge({ |
There was a problem hiding this comment.
just {args: options._doubleDashArgs, ...options} ?
|
|
||
| function ModuleInfo(plugin, policy) { | ||
| export function ModuleInfo(plugin, policy) { |
There was a problem hiding this comment.
use src/lib/plugins/types.ts : Plugin type here?...
|
Will update both in next PR |
|
🎉 This PR is included in version 1.166.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
This was referenced Sep 12, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Convert module info to typescript