-
Notifications
You must be signed in to change notification settings - Fork 555
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Vulns to use exit code 1, all other errors 2 #531
Conversation
9a4532f
to
d6c315b
Compare
7671f1e
to
1aa82dc
Compare
cb7dfbd
to
9288009
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
some of those need to go back to console.log()
@darscan Could you please elaborate a bit on why we need to go back to |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm completely OK with the changes, but let's takes @darscan's points into account.
Also, we shouldn't use Right now, we're truncating the output by terminating too aggressively. Instead, let's set the exit code, and let node terminate normally. i.e. Note: this might be hard |
} | ||
|
||
if (!args.options.json) { | ||
console.log(alerts.displayAlerts()); | ||
} | ||
|
||
if (!process.env.TAP && failed) { | ||
process.exit(1); | ||
debug('Exit code: ' + exitCode); | ||
process.exitCode = exitCode; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let it finish before exiting
3217f55
to
abf1e78
Compare
Before
After
|
4b108be
to
d77ca69
Compare
d77ca69
to
136adc5
Compare
136adc5
to
636628f
Compare
I'm getting |
fixed in a separate PR and released #537 |
normal, single target, with without vulnsoutput exactly the same as before Before
After
normal, single target, with vulnsOutput OK, analytics size is now much reduced from:
Before
After
normal, multiple target, with vulnsBefore
After
|
normal, multiple paths, with vulns -d
Before
After
|
normal, single target, with with vulns --jsonBefore
After
|
normal, single target, with with vulns
|
🎉 This PR is included in version 1.169.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
What does this PR do?
Additional questions