Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

replace node-uuid with uuid #63

Closed
wants to merge 1 commit into from
Closed

replace node-uuid with uuid #63

wants to merge 1 commit into from

Conversation

marudor
Copy link
Contributor

@marudor marudor commented Dec 5, 2016

  • Ready for review
  • Follows CONTRIBUTING rules
  • Reviewed by Snyk internal team

What does this PR do?

Simple replace of the node-uuid package with uuid.
Same developer. But the name changed and node-uuid is deprecated.

@CLAassistant
Copy link

CLAassistant commented Dec 5, 2016

CLA assistant check
All committers have signed the CLA.

@gjvis
Copy link
Contributor

gjvis commented Dec 9, 2016

Hi @marudor, thanks for submitting this! It may take some time to review and get merged as we have a lot of things in the pipeline, but it will happen 😄

@XhmikosR
Copy link

Can this be merged? It's a pretty straight-forward change.

@adrukh
Copy link
Contributor

adrukh commented Dec 16, 2016

@XhmikosR
We are working on a new release, will include this PR in it! :)

@joshje
Copy link
Contributor

joshje commented Dec 16, 2016

Hi @marudor, this is now merged into master: f67d324

Once tests run and pass there will be a new release including uuid.

@joshje joshje closed this Dec 16, 2016
@joshje
Copy link
Contributor

joshje commented Dec 16, 2016

Released as part of v1.22.0 (https://github.com/Snyk/snyk/releases/latest)

@XhmikosR
Copy link

Thanks!

joshje referenced this pull request in joshje/snyk Jan 13, 2017
fix: finding deduped packages for patching
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants