Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: switch to open (opn was deprecated and renamed to open) #749

Closed
wants to merge 1 commit into from
Closed

feat: switch to open (opn was deprecated and renamed to open) #749

wants to merge 1 commit into from

Conversation

orkamara
Copy link
Contributor

@orkamara orkamara commented Aug 25, 2019 •
edited by dkontorovskyy
Loading

  • Ready for review
  • Follows CONTRIBUTING rules
  • Reviewed by Snyk internal team

What does this PR do?

Switch using opn package to open. opn is deprecated and renamed to open.

@orkamara orkamara requested a review from a team as a code owner August 25, 2019 09:26
@orkamara orkamara self-assigned this Aug 25, 2019
@ghost ghost requested a review from lwywoo August 25, 2019 09:26
@dkontorovskyy
Copy link
Contributor

Brought by @jamesgeorge007 in #746

@dkontorovskyy
Copy link
Contributor

@jamesgeorge007, unfortunately we need to put this PR on hold, cos of 2 reasons:

  1. open@6+ doesn't support node versions less than 8 (has inside async/await functions). And this is very crucial for us, cos we need to support node 6.
  2. Needs to be properly tested, cos could bring bugs in out standalone binaries. (zeit already has this issue Support open (renamed version of opn) vercel/pkg#731)

@aliscco aliscco mentioned this pull request May 11, 2022
Open
@cloudgeek7 cloudgeek7 mentioned this pull request May 11, 2022
Open
@robin-qualityengineer robin-qualityengineer mentioned this pull request May 23, 2022
Open
This was referenced May 23, 2022
Open
Open
@froscheimer froscheimer mentioned this pull request May 24, 2022
Open
@snyk-bot snyk-bot mentioned this pull request May 24, 2022
Open
@snyk-bot snyk-bot mentioned this pull request Jun 24, 2022
Open
@EitanGayor EitanGayor mentioned this pull request Jun 30, 2022
Open
@aliscco aliscco mentioned this pull request Aug 5, 2022
Open
@snyk-bot snyk-bot mentioned this pull request Sep 24, 2022
Open
This was referenced Sep 25, 2022
Open
Open
@snyk-bot snyk-bot mentioned this pull request Oct 1, 2022
Open
@aliscco aliscco mentioned this pull request Oct 2, 2022
Open
@snyk-bot snyk-bot mentioned this pull request Oct 4, 2022
Closed
@snyk-bot snyk-bot mentioned this pull request Oct 29, 2022
Open
@darscan darscan deleted the feat/switch-to-open branch January 20, 2023 17:53
This was referenced Feb 19, 2023
Merged
Open
@cloudgeek7 cloudgeek7 mentioned this pull request Mar 15, 2023
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dkontorovskyy dkontorovskyy Awaiting requested review from dkontorovskyy

@lwywoo lwywoo Awaiting requested review from lwywoo

Assignees

@orkamara orkamara

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@orkamara @dkontorovskyy @jamesgeorge007