Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: stop sending full error to bq #958

Merged
merged 1 commit into from
Jan 12, 2020
Merged

fix: stop sending full error to bq #958

merged 1 commit into from
Jan 12, 2020

Conversation

orsagie
Copy link
Contributor

@orsagie orsagie commented Jan 12, 2020

  • Ready for review
  • Follows CONTRIBUTING rules
  • Reviewed by Snyk internal team

What does this PR do?

instead of sending full json string of error, only send that there was an error

@orsagie orsagie requested a review from a team as a code owner January 12, 2020 08:42
@ghost ghost requested review from dkontorovskyy and gitphill January 12, 2020 08:43
dkontorovskyy
dkontorovskyy reviewed Jan 12, 2020
View reviewed changes
Copy link
Contributor

@dkontorovskyy dkontorovskyy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe let's send at least error.message?

@orsagie orsagie closed this Jan 12, 2020
@orsagie orsagie reopened this Jan 12, 2020
dkontorovskyy
dkontorovskyy approved these changes Jan 12, 2020
View reviewed changes
Copy link
Contributor

@dkontorovskyy dkontorovskyy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@orsagie orsagie merged commit 1813f8a into master Jan 12, 2020
@orsagie orsagie deleted the fix/sending-full-error-to-bq branch January 12, 2020 14:27
@snyksec
Copy link

snyksec commented Jan 12, 2020

🎉 This PR is included in version 1.278.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

@logangeorgebrown logangeorgebrown mentioned this pull request Jun 21, 2023
Closed
@AliADDOU AliADDOU mentioned this pull request Jun 22, 2023
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dkontorovskyy dkontorovskyy dkontorovskyy approved these changes

@gitphill gitphill Awaiting requested review from gitphill

Assignees
No one assigned
Labels
released
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@orsagie @snyksec @dkontorovskyy