Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: release docker sbt image 1.3.5 #997

Closed
wants to merge 2 commits into from
Closed

Conversation

lili2311
Copy link
Contributor

@lili2311 lili2311 commented Feb 7, 2020

  • Ready for review
  • Follows CONTRIBUTING rules
  • Reviewed by Snyk internal team

What does this PR do?

Docker image for snyk cli and sbt 1.3.5

@lili2311 lili2311 requested a review from a team as a code owner February 7, 2020 11:12
@ghost ghost requested review from dkontorovskyy and gitphill February 7, 2020 11:12
@@ -0,0 +1,44 @@
FROM openjdk:8-jdk-slim
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

when should we move to higher java versions?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can try 11 yep!

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

added 11 too

gitphill
gitphill previously approved these changes Feb 10, 2020
@garethr
Copy link
Contributor

garethr commented Apr 24, 2020

Just to note that the experimental images have a Scala image snyk/snyk:scala available.

@lili2311 lili2311 closed this May 1, 2020
@lili2311 lili2311 reopened this May 1, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants