Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: skip file as a version key #26

Merged
merged 1 commit into from
Nov 14, 2018
Merged

fix: skip file as a version key #26

merged 1 commit into from
Nov 14, 2018

Conversation

miiila
Copy link
Contributor

@miiila miiila commented Nov 13, 2018

  • Tests written and linted ℹ︎
  • Documentation written ℹ︎
  • Commit history is tidy ℹ︎

What this does

Dependency can be specified as semver compatible string, git link oreven as a file path. In that case, dependency doesn't appear in package-lock / yarn.lock can't be looked up.

More information

@miiila miiila self-assigned this Nov 13, 2018
lili2311
lili2311 previously approved these changes Nov 13, 2018
lib/parsers/index.ts Outdated Show resolved Hide resolved
@miiila miiila force-pushed the fix/skip-file-as-version branch 2 times, most recently from c307001 to 3f13570 Compare November 13, 2018 14:58
@miiila miiila dismissed lili2311’s stale review November 13, 2018 14:59

approach changed

@lili2311
Copy link
Contributor

👏 nice!

@miiila miiila merged commit 7d876e4 into master Nov 14, 2018
@miiila miiila deleted the fix/skip-file-as-version branch November 14, 2018 10:57
@snyksec
Copy link

snyksec commented Nov 14, 2018

🎉 This PR is included in version 1.7.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants