Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: support quoted keys in inline tables #15

Merged
merged 1 commit into from
Aug 16, 2021

Conversation

admons
Copy link
Contributor

@admons admons commented Aug 9, 2021

What this does

Add support for quoted keys in inline tables (and probably more toml features)

Explain why this PR exists
current toml library doesn't support quoted keys in inline tables

today we're using toml package, which was published 3 years ago and doesnt follow current TOML spec
@iarna/toml was published 1 year ago and has better support for updated spec (v0.5)

More information

@admons admons requested a review from a team as a code owner August 9, 2021 03:29
@admons admons requested a review from jan-stehlik August 9, 2021 03:29
Add support for quoted keys in inline tables (and probably more toml features)
today we're using `toml` package, which was published 3 years ago and doesnt follow current TOML spec
@iarna/toml was published 1 year ago and has better support for updated spec (v0.5)
@admons admons force-pushed the fix/support_quotes_in_toml branch from 0a7de02 to 34ed9ac Compare August 9, 2021 03:42
Copy link

@jan-stehlik jan-stehlik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, nice one @admons 🙌

@admons admons merged commit 12d7ab2 into master Aug 16, 2021
@snyksec
Copy link

snyksec commented Aug 16, 2021

🎉 This PR is included in version 1.1.7 🎉

The release is available on:

Your semantic-release bot 📦🚀

@admons admons deleted the fix/support_quotes_in_toml branch August 16, 2021 07:22
admons added a commit to snyk/snyk-python-plugin that referenced this pull request Aug 16, 2021
admons added a commit to snyk/cli that referenced this pull request Aug 16, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants