Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: use node 10 for release #100

Merged
merged 1 commit into from
Jan 30, 2020
Merged

Conversation

lili2311
Copy link
Contributor

  • Ready for review
  • Follows CONTRIBUTING rules
  • Reviewed by Snyk internal team

What does this PR do?

Fix release by using required node version for semantic release

@lili2311 lili2311 requested a review from a team as a code owner January 29, 2020 18:29
@ghost ghost requested review from aviadhahami and dkontorovskyy January 29, 2020 18:30
@gitphill
Copy link
Contributor

gitphill commented Jan 30, 2020

There's lots of different node versions being used in this circle pipeline, I can see:

  • node:6
  • node:8
  • node:10
  • node:12

Shall we default to 10? or does CLI require plugins to build/test against 6 still?
We can also bump @types/node ?

@lili2311 lili2311 merged commit da40e8e into master Jan 30, 2020
@lili2311 lili2311 deleted the fix/rnode-10-for-semantic-release branch January 30, 2020 09:40
@snyksec
Copy link

snyksec commented Jan 30, 2020

🎉 This PR is included in version 1.16.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants