fix: [SUP-1872] fixed pipfile parser #222
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
gemaxim
force-pushed
the
fix/SUP-1872/pipfile-parse-fix
branch
from
a1f659d
to
5615a1c
Compare
dotkas
approved these changes
Sep 13, 2023
|
🎉 This PR is included in version 2.0.1 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
The pipfile parser was buggy because the toml parser returns both the value of the attribute and the end position as a tuple, but we only need the value. This changes fix that.
Any background context you want to provide?
You can see in the support ticket that snyk-python-plugin fails for a Pipfile that has markers, because the regex function does not receive a string, but the tuple mentioned above.
What are the relevant tickets?
JIRA ticket SUP-1872