feat: optional dependencies support for pip, pipenv and setuptools. #234
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MarcusArdelean
commented
Feb 21, 2024
| Returns: | ||
| str: `package_name` without optional_dependencies/arbitrary identifiers | ||
| """ | ||
| package_name = re.sub(r'\[[^]]*]$', '', package_name) |
There was a problem hiding this comment.
This part of the code, as @JamesPatrickGill mentioned in a previous PR, is linear. I would have to rethink the way I process the data in order to not iterate over the dependencies. But I'm planning to do this when refactoring the pysrc.
dotkas
approved these changes
Feb 21, 2024
|
LGTM, nothing blocking, you can do in a follow-up PR. |
dotkas
reviewed
Feb 21, 2024
| @@ -246,7 +247,7 @@ def is_testable(requirement): | |||
|
|
|||
| def detect_encoding_by_bom(path): | |||
| with open(path, 'rb') as f: | |||
| raw = f.read(4) # will read less if the file is smaller | |||
| raw = f.read(NUMBER_OF_BYTES) # will read less if the file is smaller | |||
There was a problem hiding this comment.
With this one I was more referring to WHY are you reading 4 bytes 😄 Maybe call it BOM_BYTES or something like that? Naming is hard.
MarcusArdelean
force-pushed
the
feat/optional-dependencies-support
branch
from
7970c8b
to
03fdb5b
Compare
|
🎉 This PR is included in version 2.1.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
10 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Adds support for optional dependencies/arbitrary identifiers for
pip,pipenvandsetuptools. The changes for poetry need to be made in snyk-poetry-lockfile-parser.Example:
opentelemetry-distrocan be imported as it is, or if we want to import some extra features that require extra dependencies we can use the following syntax:opentelemetry-distro[otlp]which will addopentelemetry-exporter-otlpas a new top level requirement.When generating a dependency graph, both
opentelemetry-distroandopentelemetry-exporter-otlpshould be included as top level requirements.What are the relevant tickets?
Support ticket SUP-2224