Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: match python_version with wildcards (e.g. "2.*") #79

Merged
merged 1 commit into from
Aug 28, 2019

Conversation

kyegupov
Copy link
Contributor

  • Ready for review
  • Follows CONTRIBUTING rules
  • Reviewed by Snyk internal team

What does this PR do?

fixes an issue where lines like enum34==1.1.6 ; python_version == '2.*' were not supported

@kyegupov kyegupov requested a review from a team as a code owner August 27, 2019 15:51
@ghost ghost requested review from lili2311 and miiila August 27, 2019 15:51
@kyegupov kyegupov self-assigned this Aug 27, 2019
@kyegupov kyegupov force-pushed the fix/python-verson-wildcard-matching branch from 53d3959 to 5dc742e Compare August 27, 2019 15:55
@kyegupov kyegupov force-pushed the fix/python-verson-wildcard-matching branch from 5dc742e to 8edf642 Compare August 27, 2019 16:09
Copy link
Contributor

@dkontorovskyy dkontorovskyy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kyegupov kyegupov merged commit 48fb8c2 into master Aug 28, 2019
@kyegupov kyegupov deleted the fix/python-verson-wildcard-matching branch August 28, 2019 09:39
@snyksec
Copy link

snyksec commented Aug 28, 2019

🎉 This PR is included in version 1.13.2 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants