fix: Match multiple digits in package versions #96
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The new requirements parser and tests were only matching single digits in version strings, such as `2.0.1`, which falls over very quickly, for example when faced with `flask==0.12.1`. This patch fixes the parser, and adds a test
ghost
requested review from
robcresswell
commented
Dec 18, 2019
| @@ -35,7 +35,7 @@ export function parseRequirementsFile(requirementsFile: string): Requirement[] { | |||
|
|
|||
| // Regex to match against a Python package specifier. Any invalid lines (or | |||
| // lines we can't handle) should have been returned this point. | |||
| const regex = /([A-Z0-9]*)(===|==|>=|<=|>|<|~=)(\d\.?\d?\.?\d?)(.*)/i; | |||
| const regex = /([A-Z0-9]*)(!=|==|>=|<=|>|<|~=)(\d*\.?\d*\.?\d*)(.*)/i; | |||
There was a problem hiding this comment.
Also aligned this with the VersionComparator type by replacing === with !=
gitphill
approved these changes
Dec 18, 2019
robcresswell
deleted the
fix/match-multiple-digits-inpackage-versions
branch
|
🎉 This PR is included in version 1.15.1 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The new requirements parser and tests were only matching single digits in version strings, such as
2.0.1, which falls over very quickly, for example when faced withflask==0.12.1.This patch fixes the parser, and adds a test